[GitHub] carbondata pull request #2274: [CARBONDATA-2440] default value of ENABLE_OFF...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/2274

    [CARBONDATA-2440] default value of ENABLE_OFFHEAP_SORT for sdk set as  false

   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata unsafe_mem_sdk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2274
   
----
commit 3d67d58737d099458fbfd050bb256918573b8610
Author: rahulforallp <rahul.kumar@...>
Date:   2018-05-04T14:09:58Z

    [CARBONDATA-2440] false set as default value of ENABLE_OFFHEAP_SORT for sdk

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4745/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5667/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4507/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4746/



---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5671/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4511/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2274#discussion_r186921945
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -340,7 +342,13 @@ private CarbonLoadModel createLoadModel() throws IOException, InvalidLoadOptionE
           // we are still using the traditional carbon table folder structure
           persistSchemaFile(table, CarbonTablePath.getSchemaFilePath(path));
         }
    -
    +    if (!table.isTransactionalTable()) {
    +      CarbonProperties.getInstance()
    +          .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, "false");
    --- End diff --
   
    This will impact others, why not let SDK user to set it


---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2274#discussion_r187368858
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -340,7 +342,13 @@ private CarbonLoadModel createLoadModel() throws IOException, InvalidLoadOptionE
           // we are still using the traditional carbon table folder structure
           persistSchemaFile(table, CarbonTablePath.getSchemaFilePath(path));
         }
    -
    +    if (!table.isTransactionalTable()) {
    +      CarbonProperties.getInstance()
    +          .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, "false");
    --- End diff --
   
    Intention was to prevent 'unsafe' property from being used by SDK user by default.  Otherwise they have to configure memory for unsafe also. So making it simple to use.
   
    Any way we will update the doc how SDK user can set the property by following code:
   
    CarbonProperties.getInstance() .addProperty("property", "value");


---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2274#discussion_r187530598
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -340,7 +342,13 @@ private CarbonLoadModel createLoadModel() throws IOException, InvalidLoadOptionE
           // we are still using the traditional carbon table folder structure
           persistSchemaFile(table, CarbonTablePath.getSchemaFilePath(path));
         }
    -
    +    if (!table.isTransactionalTable()) {
    +      CarbonProperties.getInstance()
    +          .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, "false");
    --- End diff --
   
    But this will overwrite the ENABLE_OFFHEAP_SORT is the user has set it. Need to check if this is already set. If not then set to false otherwise use what the user has set.


---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2274#discussion_r187533693
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -340,7 +342,13 @@ private CarbonLoadModel createLoadModel() throws IOException, InvalidLoadOptionE
           // we are still using the traditional carbon table folder structure
           persistSchemaFile(table, CarbonTablePath.getSchemaFilePath(path));
         }
    -
    +    if (!table.isTransactionalTable()) {
    +      CarbonProperties.getInstance()
    +          .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, "false");
    --- End diff --
   
    @kunal642  if we are updating the doc to set the properties then no need of this code.  same PR we can use to update the doc.


---

[qiuchenjian-2]

Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5842/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4686/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4887/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5883/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4918/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4731/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2274
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4919/



---