[GitHub] carbondata pull request #2279: [CARBONDATA-2454][DataMap] Add fpp property f...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2279

    [CARBONDATA-2454][DataMap] Add fpp property for bloom datamap

    add fpp(false positive probability) property to configure bloom filter
    that used by bloom datamap.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `changed only internal used interfaces`
     - [x] Any backward compatibility impacted?
     `NO`
     - [x] Document update required?
    `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `Tests will be added in the future`
            - How it is tested? Please attach test report.
    `tested in standalone 3-node cluster`
            - Is it a performance related change? Please attach the performance test report.
    `Yes, proper fpp can improve the query performance`
            - Any additional information to help reviewers in testing this change.
           `NA`
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0508_add_bloom_ffp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2279
   
----
commit 57d2e702cce739c709bba6e352366e1d0ba773c6
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-05-08T04:00:39Z

    Add fpp property for bloom datamap
   
    add fpp(false positive probability) property to configure bloom filter
    that used by bloom datamap.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2279
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5722/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2279
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4561/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2279#discussion_r186692388
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java ---
    @@ -65,9 +65,18 @@
        * and all the indexed value is distinct.
        */
       private static final int DEFAULT_BLOOM_FILTER_SIZE = 32000 * 20;
    +  /**
    +   * property for fpp(false-positive-probability) of bloom filter
    +   */
    +  private static final String BLOOM_FPP = "bloom_fpp";
    --- End diff --
   
    Do user need to configure this? What is the relationship with DEFAULT_BLOOM_FILTER_SIZE


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2279#discussion_r186697865
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java ---
    @@ -65,9 +65,18 @@
        * and all the indexed value is distinct.
        */
       private static final int DEFAULT_BLOOM_FILTER_SIZE = 32000 * 20;
    +  /**
    +   * property for fpp(false-positive-probability) of bloom filter
    +   */
    +  private static final String BLOOM_FPP = "bloom_fpp";
    --- End diff --
   
    yes, it is an configuration for bloom filter.
   
    If
    n : bloomfilterSize
    p : fpp
   
    then
     `p` will decide the number of hash functions used internally by bloom filter
    `n` and `p` together decide the length of bits used internally by bloom filter


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2279#discussion_r186723961
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java ---
    @@ -65,9 +65,18 @@
        * and all the indexed value is distinct.
        */
       private static final int DEFAULT_BLOOM_FILTER_SIZE = 32000 * 20;
    +  /**
    +   * property for fpp(false-positive-probability) of bloom filter
    +   */
    +  private static final String BLOOM_FPP = "bloom_fpp";
    --- End diff --
   
    Can you add a testcase for it


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2279#discussion_r186724686
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java ---
    @@ -65,9 +65,18 @@
        * and all the indexed value is distinct.
        */
       private static final int DEFAULT_BLOOM_FILTER_SIZE = 32000 * 20;
    +  /**
    +   * property for fpp(false-positive-probability) of bloom filter
    +   */
    +  private static final String BLOOM_FPP = "bloom_fpp";
    --- End diff --
   
    User can always control the bloom filter memory size by setting `n`?


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2279#discussion_r186749900
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java ---
    @@ -65,9 +65,18 @@
        * and all the indexed value is distinct.
        */
       private static final int DEFAULT_BLOOM_FILTER_SIZE = 32000 * 20;
    +  /**
    +   * property for fpp(false-positive-probability) of bloom filter
    +   */
    +  private static final String BLOOM_FPP = "bloom_fpp";
    --- End diff --
   
    yes, by setting n and p, user can control the bloomfiltersize (for memory) and the number of hash function(for cpu).


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2279#discussion_r186750689
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java ---
    @@ -65,9 +65,18 @@
        * and all the indexed value is distinct.
        */
       private static final int DEFAULT_BLOOM_FILTER_SIZE = 32000 * 20;
    +  /**
    +   * property for fpp(false-positive-probability) of bloom filter
    +   */
    +  private static final String BLOOM_FPP = "bloom_fpp";
    --- End diff --
   
    Testcase will be added after your PR #2255 is merged. It makes lots of changes to the code.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2279
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2279


---