[GitHub] carbondata pull request #2307: [CARBONDATA-2482] Pass uuid while writing seg...

[qiuchenjian-2]

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/2307

    [CARBONDATA-2482] Pass uuid while writing segment file if possible

    Pass the uuid (segmentFileName) to the writeSegmentFile method file if possible
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
            UTs are already there
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/carbondata writesegFile

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2307
   
----
commit 8dffef3c1dff120ee6c4aed525e355fd0c6aff18
Author: dhatchayani <dhatcha.official@...>
Date:   2018-05-15T06:54:01Z

    [CARBONDATA-2482] Pass uuid while writing segment file if possible

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5884/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4730/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4920/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5890/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4736/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4757/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5912/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4945/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    @dhatchayani ...I have few doubts
    1. Why UUID is optional here? I can see from some methods it is passed as null and then System.currentTime is used as UUID
    2. Please update the description and give detailed explanation  which clearly defines the purpose of this PR


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2307#discussion_r202251585
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java ---
    @@ -1085,11 +1085,11 @@ public static Long addDataIndexSizeIntoMetaEntry(LoadMetadataDetails loadMetadat
        * @return
        * @throws IOException
        */
    -  public static String mergeIndexFilesinPartitionedSegment(String segmentId, CarbonTable table)
    -      throws IOException {
    +  public static String mergeIndexFilesinPartitionedSegment(String segmentId, String uuid,
    +      CarbonTable table) throws IOException {
    --- End diff --
   
    make this as the first argument


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    LGTM...can be merged once build passes


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2307#discussion_r202310789
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java ---
    @@ -145,9 +145,10 @@ private String writeMergeIndexFileBasedOnSegmentFile(
           }
         }
     
    -    String uniqueId = String.valueOf(System.currentTimeMillis());
    -    String newSegmentFileName =
    -        SegmentFileStore.genSegmentFileName(segmentId, String.valueOf(uniqueId))
    +    String uniqueId = (uuid.endsWith(CarbonTablePath.SEGMENT_EXT)) ?
    --- End diff --
   
    Don't pass segment file name, just pass only uuid .


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5820/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7113/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5831/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5889/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5843/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2307
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7182/



---