[GitHub] carbondata pull request #2357: [CARBONDATA-2569] Search mode throw exception...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2357

    [CARBONDATA-2569] Search mode throw exception but test case pass

    [CARBONDATA-2569] Search mode throw exception but test case pass, please check the jira
   
    This PR move the run the sparkSQL after search mode has exception
   
     - [X] Any interfaces changed?
     NO
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
     run test case searchModeTestCase
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2569-SearchModeException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2357
   
----
commit 9f349c39d8714c4e1197dfc547aecb76b58a17d3
Author: xubo245 <xubo29@...>
Date:   2018-06-01T03:50:52Z

    [CARBONDATA-2569] Search mode throw exception but test case pass

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5193/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6218/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6219/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5057/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5059/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6221/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    @jackylk Please review it


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6226/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5064/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5198/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6230/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5069/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2357
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5202/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2357#discussion_r192418789
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -171,19 +170,25 @@ class CarbonSession(@transient val sc: SparkContext,
        */
       private def trySearchMode(qe: QueryExecution, sse: SQLStart): DataFrame = {
         val analyzed = qe.analyzed
    +    val LOG: LogService = LogServiceFactory.getLogService(classOf[CarbonSession].getName)
         analyzed match {
           case _@Project(columns, _@Filter(expr, s: SubqueryAlias))
             if s.child.isInstanceOf[LogicalRelation] &&
                s.child.asInstanceOf[LogicalRelation].relation
                  .isInstanceOf[CarbonDatasourceHadoopRelation] =>
    +        LOG.info(String.format("Search service started and supports: %s", sse.sqlText))
             runSearch(analyzed, columns, expr, s.child.asInstanceOf[LogicalRelation])
           case gl@GlobalLimit(_, ll@LocalLimit(_, p@Project(columns, _@Filter(expr, s: SubqueryAlias))))
             if s.child.isInstanceOf[LogicalRelation] &&
                s.child.asInstanceOf[LogicalRelation].relation
                  .isInstanceOf[CarbonDatasourceHadoopRelation] =>
             val logicalRelation = s.child.asInstanceOf[LogicalRelation]
    +        LOG.info(String.format("Search service started and supports: %s", sse.sqlText))
             runSearch(analyzed, columns, expr, logicalRelation, gl.maxRows, ll.maxRows)
           case _ =>
    +        LOG.info(String.format(
    --- End diff --
   
    same as above


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2357#discussion_r192420617
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -171,19 +170,25 @@ class CarbonSession(@transient val sc: SparkContext,
        */
       private def trySearchMode(qe: QueryExecution, sse: SQLStart): DataFrame = {
         val analyzed = qe.analyzed
    +    val LOG: LogService = LogServiceFactory.getLogService(classOf[CarbonSession].getName)
         analyzed match {
           case _@Project(columns, _@Filter(expr, s: SubqueryAlias))
             if s.child.isInstanceOf[LogicalRelation] &&
                s.child.asInstanceOf[LogicalRelation].relation
                  .isInstanceOf[CarbonDatasourceHadoopRelation] =>
    +        LOG.info(String.format("Search service started and supports: %s", sse.sqlText))
             runSearch(analyzed, columns, expr, s.child.asInstanceOf[LogicalRelation])
           case gl@GlobalLimit(_, ll@LocalLimit(_, p@Project(columns, _@Filter(expr, s: SubqueryAlias))))
             if s.child.isInstanceOf[LogicalRelation] &&
                s.child.asInstanceOf[LogicalRelation].relation
                  .isInstanceOf[CarbonDatasourceHadoopRelation] =>
             val logicalRelation = s.child.asInstanceOf[LogicalRelation]
    +        LOG.info(String.format("Search service started and supports: %s", sse.sqlText))
             runSearch(analyzed, columns, expr, logicalRelation, gl.maxRows, ll.maxRows)
           case _ =>
    +        LOG.info(String.format(
    +          "Search service started, but don't support: %s, and running it with SparkSQL",
    --- End diff --
   
    and will run it with SparkSQL


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2357#discussion_r192418603
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -101,8 +100,8 @@ class CarbonSession(@transient val sc: SparkContext,
               } catch {
                 case e: Exception =>
                   logError(String.format(
    --- End diff --
   
    It is in scala here, why still use `String.format`? Just use s"....$var..."


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2357#discussion_r192418722
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -171,19 +170,25 @@ class CarbonSession(@transient val sc: SparkContext,
        */
       private def trySearchMode(qe: QueryExecution, sse: SQLStart): DataFrame = {
         val analyzed = qe.analyzed
    +    val LOG: LogService = LogServiceFactory.getLogService(classOf[CarbonSession].getName)
         analyzed match {
           case _@Project(columns, _@Filter(expr, s: SubqueryAlias))
             if s.child.isInstanceOf[LogicalRelation] &&
                s.child.asInstanceOf[LogicalRelation].relation
                  .isInstanceOf[CarbonDatasourceHadoopRelation] =>
    +        LOG.info(String.format("Search service started and supports: %s", sse.sqlText))
             runSearch(analyzed, columns, expr, s.child.asInstanceOf[LogicalRelation])
           case gl@GlobalLimit(_, ll@LocalLimit(_, p@Project(columns, _@Filter(expr, s: SubqueryAlias))))
             if s.child.isInstanceOf[LogicalRelation] &&
                s.child.asInstanceOf[LogicalRelation].relation
                  .isInstanceOf[CarbonDatasourceHadoopRelation] =>
             val logicalRelation = s.child.asInstanceOf[LogicalRelation]
    +        LOG.info(String.format("Search service started and supports: %s", sse.sqlText))
    --- End diff --
   
    same as above


---