[GitHub] carbondata pull request #2387: [CARBONDATA-2621][BloomDataMap] Lock problem ...

[qiuchenjian-2]

GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/carbondata/pull/2387

    [CARBONDATA-2621][BloomDataMap] Lock problem in index datamap

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     None
     - [X] Any backward compatibility impacted?
     None
     - [X] Document update required?
    None
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Corrected the test case.
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata bloom_lock_issue_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2387
   
----
commit a1e72c53822d3f7d3c2cbe4fc13e1a98e95d9a3a
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date:   2018-06-20T10:18:17Z

    [CARBONDATA-2621][BloomDataMap] Lock problem in index datamap

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5246/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6412/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5256/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6422/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5259/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6427/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5360/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5365/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2387#discussion_r197010690
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -1530,6 +1531,22 @@ public String getSystemFolderLocation() {
         if (systemLocation == null) {
           systemLocation = getStorePath();
         }
    +    // append the HDFS uri to the system folder if not already added.
    +    systemLocation = CarbonUtil.checkAndAppendFileSystemURIScheme(systemLocation);
    +    FileFactory.FileType fileType = FileFactory.getFileType(systemLocation);
    +    switch (fileType) {
    +      case HDFS:
    +      case VIEWFS:
    +      case ALLUXIO:
    +        break;
    +      case LOCAL:
    +        // for local fs remove the URI scheme and unify the path representation
    +        systemLocation = FileFactory.getUpdatedFilePath(systemLocation);
    +        break;
    +      default:
    +        // for local fs remove the URI scheme and unify the path representation
    +        systemLocation = FileFactory.getUpdatedFilePath(systemLocation);
    +    }
    --- End diff --
   
    switch case is not required here as only one operation is performed...you can directly write
    systemLocation = FileFactory.getUpdatedFilePath(CarbonUtil.checkAndAppendFileSystemURIScheme(systemLocation));
   
    getUpdatedFilePath will internally handle to make the required modification only for Local file system


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2387#discussion_r197014465
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -1530,6 +1531,22 @@ public String getSystemFolderLocation() {
         if (systemLocation == null) {
           systemLocation = getStorePath();
         }
    +    // append the HDFS uri to the system folder if not already added.
    +    systemLocation = CarbonUtil.checkAndAppendFileSystemURIScheme(systemLocation);
    +    FileFactory.FileType fileType = FileFactory.getFileType(systemLocation);
    +    switch (fileType) {
    +      case HDFS:
    +      case VIEWFS:
    +      case ALLUXIO:
    +        break;
    +      case LOCAL:
    +        // for local fs remove the URI scheme and unify the path representation
    +        systemLocation = FileFactory.getUpdatedFilePath(systemLocation);
    +        break;
    +      default:
    +        // for local fs remove the URI scheme and unify the path representation
    +        systemLocation = FileFactory.getUpdatedFilePath(systemLocation);
    +    }
    --- End diff --
   
    Thanks @manishgupta88 , missed to to check the internal implementation of FileFactory.getUpdatedFilePath().


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2387#discussion_r197015265
 
    --- Diff: integration/spark2/src/test/scala/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapSuite.scala ---
    @@ -37,6 +39,11 @@ class BloomCoarseGrainDataMapSuite extends QueryTest with BeforeAndAfterAll with
       val dataMapName = "bloom_dm"
     
       override protected def beforeAll(): Unit = {
    +    val path: String = new File(
    +      classOf[DiskBasedDMSchemaStorageProvider].getResource("/").getPath + "../").getCanonicalPath
    +      .replaceAll("\\\\", "/")
    --- End diff --
   
    Also check if there is any generic location that we can give here...may be you can take reference from the spark UT framework where we add the location in spark-common


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    LGTM...can be merged once build passes


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6436/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5267/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6441/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5272/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5371/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2387
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6450/



---