GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2393 [CARBONDATA-2626] Fix bugs in sequence of column page In tableSpec, the sort column dimensions are in the left of those dictionary dimensions. Create table and load data to it. The table schema is: ``` sql( s""" | CREATE TABLE $bloomDMSampleTable(id INT, name STRING, city STRING, age INT, | s1 STRING, s2 STRING, s3 STRING, s4 STRING, s5 STRING, s6 STRING, s7 STRING, s8 STRING) | STORED BY 'carbondata' TBLPROPERTIES('table_blocksize'='128', 'dictionary_include'='id', 'sort_columns'='name') | """.stripMargin) ``` Â In tablespec, the first dimension spec is 'name' which is sort_columns but not dictionary. But Carbondata now treat it as dictionary page. (See TablePage Line94) Â Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuchuanyin/carbondata 0621_bug_column_page_seq Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2393.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2393 ---- commit d46aac7d0aa5a5382bb57886103d6f5897c4ae43 Author: xuchuanyin <xuchuanyin@...> Date: 2018-06-21T09:51:30Z Fix bugs in sequence of column page In tableSpec, the sort column dimensions are in the left of those dictionary dimensions. ---- --- |
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2393 retest this please --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2393 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6459/ --- |
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2393 retest this please --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2393 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5384/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2393 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6461/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2393 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5292/ --- |
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2393 Have you tested using data generated by 1.4.0 and read by this PR, to ensure the backward compatibility? --- |
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2393 I've tested it, it's OK. please refer to the description of this PR --- |
In reply to this post by qiuchenjian-2
|
In reply to this post by qiuchenjian-2
|
Free forum by Nabble | Edit this page |