[GitHub] carbondata pull request #2403: [CARBONDATA-2632][BloomDataMap] Fix bugs in b...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2403

    [CARBONDATA-2632][BloomDataMap] Fix bugs in bloomfilter for dictionary/sort/date/TimeStamp column

    In carbondata,
   
    for dictionary column, carbon convert literal value to dict value, then
    convert dict value to mdk value, at last it stores the mdk value as
    internal value in carbonfile.
   
    for other columns, carbon convert literal value to internal value using
    field-converter.
   
    Since bloomfilter datamap stores the internal value, during query we
    should convert the literal value in filter to internal value in order to
    match the value stored in bloomfilter datamap.
   
    Changes are made:
    1. FieldConverters were refactored to extract common value convert methods.
    2. BloomQueryModel was optimized to support converting literal value to
    internal value.
    3. fix bugs for int/float/date/timestamp as bloom index column
    4. fix bugs in dictionary/sort column as bloom index column
    5. add tests
    6. block (deferred) rebuild for bloom datamap (contains bugs that does
    not fix in this commit)
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `No`
     - [x] Any backward compatibility impacted?
     `Yes. Because the encoding of the index value has changed. Besides, deferred build of bloom datamap has been blocked in this PR, will do it later`
     - [x] Document update required?
    `No`
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `Added tests`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
    `Query performance with bloomfilter may decrease, because it contains extra value-convert procedure`
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0621_bloom_dict_sort_int_date

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2403
   
----
commit 0cf11cd443cd4531180e0e674cc870dbed867fe3
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-06-24T02:06:54Z

    Fix bugs in bloomfilter for dictionary/sort/date column
   
    In carbondata,
   
    for dictionary column, carbon convert literal value to dict value, then
    convert dict value to mdk value, at last it stores the mdk value as
    internal value in carbonfile.
   
    for other columns, carbon convert literal value to internal value using
    field-converter.
   
    Since bloomfilter datamap stores the internal value, during query we
    should convert the literal value in filter to internal value in order to
    match the value stored in bloomfilter datamap.
   
    Changes are made:
    1. FieldConverters were refactored to extract common value convert methods.
    2. BloomQueryModel was optimized to support converting literal value to
    internal value.
    3. fix bugs for int/float/date/timestamp as bloom index column
    4. fix bugs in dictionary/sort column as bloom index column
    5. add tests
    6. block (deferred) rebuild for bloom datamap (contains bugs that does
    not fix in this commit)

----


---

[qiuchenjian-2]

Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/2403


---

[qiuchenjian-2]

GitHub user xuchuanyin reopened a pull request:

    https://github.com/apache/carbondata/pull/2403

    [CARBONDATA-2633][BloomDataMap] Fix bugs in bloomfilter for dictionary/sort/date/TimeStamp column

    In carbondata,
   
    for dictionary column, carbon convert literal value to dict value, then
    convert dict value to mdk value, at last it stores the mdk value as
    internal value in carbonfile.
   
    for other columns, carbon convert literal value to internal value using
    field-converter.
   
    Since bloomfilter datamap stores the internal value, during query we
    should convert the literal value in filter to internal value in order to
    match the value stored in bloomfilter datamap.
   
    Changes are made:
    1. FieldConverters were refactored to extract common value convert methods.
    2. BloomQueryModel was optimized to support converting literal value to
    internal value.
    3. fix bugs for int/float/date/timestamp as bloom index column
    4. fix bugs in dictionary/sort column as bloom index column
    5. add tests
    6. block (deferred) rebuild for bloom datamap (contains bugs that does
    not fix in this commit)
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `No`
     - [x] Any backward compatibility impacted?
     `Yes. Because the encoding of the index value has changed. Besides, deferred build of bloom datamap has been blocked in this PR, will do it later`
     - [x] Document update required?
    `No`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `Added tests`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
    `Query performance with bloomfilter may decrease, because it contains extra value-convert procedure`
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0621_bloom_dict_sort_int_date

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2403
   
----
commit 0cf11cd443cd4531180e0e674cc870dbed867fe3
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-06-24T02:06:54Z

    Fix bugs in bloomfilter for dictionary/sort/date column
   
    In carbondata,
   
    for dictionary column, carbon convert literal value to dict value, then
    convert dict value to mdk value, at last it stores the mdk value as
    internal value in carbonfile.
   
    for other columns, carbon convert literal value to internal value using
    field-converter.
   
    Since bloomfilter datamap stores the internal value, during query we
    should convert the literal value in filter to internal value in order to
    match the value stored in bloomfilter datamap.
   
    Changes are made:
    1. FieldConverters were refactored to extract common value convert methods.
    2. BloomQueryModel was optimized to support converting literal value to
    internal value.
    3. fix bugs for int/float/date/timestamp as bloom index column
    4. fix bugs in dictionary/sort column as bloom index column
    5. add tests
    6. block (deferred) rebuild for bloom datamap (contains bugs that does
    not fix in this commit)

----


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5411/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5321/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6490/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6508/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5340/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6516/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5348/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    it depends on PR #2408


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5433/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5351/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6520/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5434/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2403#discussion_r199041719
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java ---
    @@ -175,6 +297,7 @@ public boolean isScanRequired(FilterResolverIntf filterExp) {
       public void clear() {
         bloomIndexList.clear();
         bloomIndexList = null;
    +
    --- End diff --
   
    remove it


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2403#discussion_r199041785
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java ---
    @@ -187,21 +310,18 @@ public static String getBloomIndexFile(String shardPath, String colName) {
       }
       static class BloomQueryModel {
         private String columnName;
    -    private DataType dataType;
    -    private Object filterValue;
    +    private byte[] filterValue;
     
    -    private BloomQueryModel(String columnName, DataType dataType, Object filterValue) {
    +    private BloomQueryModel(String columnName, byte[] filterValue) {
    --- End diff --
   
    please describe the `filterValue`


---