[GitHub] carbondata pull request #2418: [WIP] [CARBONDATA-2647] [CARBONDATA-2648] Add...

[qiuchenjian-2]

GitHub user manishgupta88 opened a pull request:

    https://github.com/apache/carbondata/pull/2418

    [WIP] [CARBONDATA-2647] [CARBONDATA-2648] Add support for COLUMN_META_CACHE and CACHE_LEVEL in create table and alter table properties

    Things done as part of this PR
    1. Support for configuring COLUMN_META_CACHE in create and alter table set properties DDL.
    2. Support for configuring CACHE_LEVEL in create and alter table set properties DDL.
    3. Describe formatted display support for COLUMN_META_CACHE and CACHE_LEVEL
   
    **Pending Task:** Adding UT and FT
   
     - [ ] Any interfaces changed?
   
    **Create Table Syntax**
    CREATE TABLE [dbName].tableName (col1 String, col2 String, col3 int,…) STORED BY ‘carbondata’ TBLPROPERTIES (‘COLUMN_META_CACHE’=’col1,col2,…’, 'CACHE_LEVEL'='BLOCKLET')
   
    **Alter Table set properties Syntax**
    ALTER TABLE [dbName].tableName SET TBLPROPERTIES (‘COLUMN_META_CACHE’=’col1,col2,…’, 'CACHE_LEVEL'='BLOCKLET')
   
     - [ ] Any backward compatibility impacted?
    No
     - [ ] Document update required?
    Yes
     - [ ] Testing done
    Manually verified. UT and FT will be added      
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manishgupta88/carbondata ddl_column_meta_cache

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2418
   
----
commit 29329e50ff732a44571cfccb1f11e784d2882dc5
Author: manishgupta88 <tomanishgupta18@...>
Date:   2018-06-26T14:41:14Z

    Add support for cache level and column meta cache in create and alter DDL

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6578/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5407/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5476/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2418#discussion_r198531901
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -1165,4 +1165,30 @@ private static void setLocalDictInfo(CarbonTable table, TableInfo tableInfo) {
           table.setLocalDictionaryEnabled(Boolean.parseBoolean("false"));
         }
       }
    +
    +  /**
    +   * Method to get the list of cached columns of the table
    +   *
    +   * @param tableName
    +   * @return
    +   */
    +  public List<String> getCachedColumns(String tableName) {
    +    List<String> cachedColsList = new ArrayList<>(tableDimensionsMap.size());
    +    String cacheColumns =
    +        tableInfo.getFactTable().getTableProperties().get(CarbonCommonConstants.COLUMN_META_CACHE);
    +    List<CarbonDimension> carbonDimensions = tableDimensionsMap.get(tableName);
    --- End diff --
   
    Check in complete columns not just dimensions


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2418#discussion_r198542124
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -1165,4 +1165,30 @@ private static void setLocalDictInfo(CarbonTable table, TableInfo tableInfo) {
           table.setLocalDictionaryEnabled(Boolean.parseBoolean("false"));
         }
       }
    +
    +  /**
    +   * Method to get the list of cached columns of the table
    +   *
    +   * @param tableName
    +   * @return
    +   */
    +  public List<String> getCachedColumns(String tableName) {
    +    List<String> cachedColsList = new ArrayList<>(tableDimensionsMap.size());
    +    String cacheColumns =
    +        tableInfo.getFactTable().getTableProperties().get(CarbonCommonConstants.COLUMN_META_CACHE);
    +    List<CarbonDimension> carbonDimensions = tableDimensionsMap.get(tableName);
    --- End diff --
   
    Ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6592/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6599/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5486/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5487/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5425/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2418
 
    @ravipesala ...handled review comments..all builds passed...kindly review and merge


---