[GitHub] carbondata pull request #2423: [CARBONDATA-2530][MV] Fix wrong data displaye...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2423

    [CARBONDATA-2530][MV] Fix wrong data displayed when parent table data are loaded

    This PR fixed the  wrong data displayed when parent table data are loaded after rebuild for datamap, including insert into and load
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
          add test case for it
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2530-displayed-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2423
   
----
commit 88e85b000901e6117be54441ced3735e4aca739f
Author: xubo245 <xubo29@...>
Date:   2018-06-27T09:54:44Z

    [CARBONDATA-2530][MV] Fix wrong data displayed when parent table data are loaded

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2423
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6587/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2423
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5411/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2423
 
    @ravipesala @jackylk Please review it.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2423#discussion_r199315133
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala ---
    @@ -75,6 +77,13 @@ class MVAnalyzerRule(sparkSession: SparkSession) extends Rule[LogicalPlan] {
             plan
           }
         } else {
    +      if (catalog != null && (plan.isInstanceOf[InsertIntoCarbonTable]
    --- End diff --
   
    please move `(plan.isInstanceOf[InsertIntoCarbonTable]` to next line


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2423#discussion_r199315149
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala ---
    @@ -75,6 +77,13 @@ class MVAnalyzerRule(sparkSession: SparkSession) extends Rule[LogicalPlan] {
             plan
           }
         } else {
    +      if (catalog != null && (plan.isInstanceOf[InsertIntoCarbonTable]
    +        || plan.isInstanceOf[CarbonLoadDataCommand])) {
    +        val allSchema = catalog.asInstanceOf[SummaryDatasetCatalog].listAllSchema()
    +        for (schema <- allSchema) {
    --- End diff --
   
    use `foreach` instead of `for` which is faster in Scala


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2423
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7104/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2423
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5880/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2423
 
    @xubo245 Please close it, it is handled in https://github.com/apache/carbondata/pull/2474


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2423
 
    @ravipesala ok


---

[qiuchenjian-2]

Github user xubo245 closed the pull request at:

    https://github.com/apache/carbondata/pull/2423


---