[GitHub] carbondata pull request #2448: [HotFix] Getting carbon table identifier to d...

[qiuchenjian-2]

GitHub user jatin9896 opened a pull request:

    https://github.com/apache/carbondata/pull/2448

    [HotFix] Getting carbon table identifier to datamap events

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? NO
     
     - [ ] Any backward compatibility impacted? NO
     
     - [ ] Document update required? NO
   
     - [ ] Testing done NA
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jatin9896/incubator-carbondata hotfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2448.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2448
   
----
commit c0d23c8d6529fff5af8bcb8730c817d75e5da1ca
Author: Jatin <jatin.demla@...>
Date:   2018-07-04T14:23:48Z

    getting carbon table identifier to datamap events

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5594/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6772/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5616/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5618/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2448#discussion_r200258280
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDropDataMapCommand.scala ---
    @@ -201,12 +201,12 @@ case class CarbonDropDataMapCommand(
             val operationContext: OperationContext = new OperationContext()
             val systemFolderLocation: String = CarbonProperties.getInstance().getSystemFolderLocation
             val updateDataMapPreExecutionEvent: UpdateDataMapPreExecutionEvent =
    -          UpdateDataMapPreExecutionEvent(sparkSession, systemFolderLocation)
    +          UpdateDataMapPreExecutionEvent(sparkSession, systemFolderLocation, table.get)
             OperationListenerBus.getInstance().fireEvent(updateDataMapPreExecutionEvent,
               operationContext)
             DataMapStatusManager.dropDataMap(dataMapSchema.getDataMapName)
             val updateDataMapPostExecutionEvent: UpdateDataMapPostExecutionEvent =
    -          UpdateDataMapPostExecutionEvent(sparkSession, systemFolderLocation)
    +          UpdateDataMapPostExecutionEvent(sparkSession, systemFolderLocation,table.get)
    --- End diff --
   
    need a space after comma


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6800/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6856/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5646/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5674/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6908/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5693/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5703/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7101/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5877/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2448
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5840/



---