[GitHub] carbondata pull request #2459: [WIP][CarbonStore] CarbonStore Java API

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2459

    [WIP][CarbonStore] CarbonStore Java API

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata store-api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2459
   
----
commit fa111380fc46c955330bc47b802844e576b6524f
Author: Jacky Li <jacky.likun@...>
Date:   2018-06-13T15:57:00Z

    [CARBONDATA-2609] Change RPC implementation to Hadoop RPC framework
   
    This closes #2372

commit 6fa86381f82d5907e366ef6707d731a228ac4081
Author: QiangCai <qiangcai@...>
Date:   2018-07-03T12:21:18Z

    [CARBONDATA-2690][CarbonStore] implement RESTful API: create table, load data and select
   
    This PR adds:
    1.basic framework
    rewrite the carbon store's Master, Worker and Scheduler code in Java
   
    2.RESTful API
    support create a table by using file meta store
    support load data to a table in single work
    support select data with a filter
   
    This closes #2440

commit 9132fa299d4a260a2de9f8115b8de7b314828df9
Author: Jacky Li <jacky.likun@...>
Date:   2018-07-06T07:37:17Z

    wip

commit df845e10a11a10b073b9d91ed637da46bf70a351
Author: Jacky Li <jacky.likun@...>
Date:   2018-07-06T08:17:41Z

    wip

commit 30f077207b4cab2ccda48afbb2ffa5c62ea4270c
Author: Jacky Li <jacky.likun@...>
Date:   2018-07-06T08:17:50Z

    wip

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6884/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6889/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5666/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6904/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5670/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5686/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6906/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5672/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5673/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2459
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5691/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2459#discussion_r200862646
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/SearchModeTestCase.scala ---
    @@ -28,7 +28,7 @@ import org.apache.carbondata.spark.util.DataGenerator
     /**
      * Test Suite for search mode
      */
    -
    +@Ignore
    --- End diff --
   
    why do you ignore these test cases?


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2459#discussion_r200862539
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -196,7 +196,7 @@ struct DataMapSchema  {
         // class name
         2: required string className;
         // to maintain properties which are mentioned in DMPROPERTIES of DDL and also it
    -    // stores properties of select query, query type like groupby, join in
    --- End diff --
   
    not required this modification.
    maybe it is a re-factory mistake.


---

[qiuchenjian-2]

Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/2459


---