[GitHub] carbondata pull request #2461: [CARBONDATA-2706][BloomDataMap] clear bloom i...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2461

    [CARBONDATA-2706][BloomDataMap] clear bloom index files after segment is deleted

    clear bloom index files after corresponding segment is deleted and
    cleaned
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata CARBONDATA_2706_clear_index_file

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2461
   
----
commit 56caafab5d8949f4dcc71fcb5cf4c0b55abef077
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-07-09T03:36:13Z

    clear bloom index files after segment is deleted
   
    clear bloom index files after corresponding segment is deleted and
    cleaned

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6932/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5705/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5717/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2461#discussion_r200894373
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java ---
    @@ -110,6 +110,10 @@ public abstract DataMapBuilder createBuilder(Segment segment, String shardName,
        */
       public abstract DataMapLevel getDataMapLevel();
     
    +  /**
    +   * delete datamap of the segment
    +   */
    +  public abstract void deleteDatamapData(Segment segment);
       /**
    --- End diff --
   
    add one extra empty line


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2461#discussion_r200894441
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java ---
    @@ -110,6 +110,10 @@ public abstract DataMapBuilder createBuilder(Segment segment, String shardName,
        */
       public abstract DataMapLevel getDataMapLevel();
     
    +  /**
    +   * delete datamap of the segment
    --- End diff --
   
    change to `delete datamap data in the specified segment


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6942/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5725/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2461#discussion_r200966900
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java ---
    @@ -110,6 +110,10 @@ public abstract DataMapBuilder createBuilder(Segment segment, String shardName,
        */
       public abstract DataMapLevel getDataMapLevel();
     
    +  /**
    +   * delete datamap of the segment
    +   */
    +  public abstract void deleteDatamapData(Segment segment);
       /**
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2461#discussion_r200967301
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java ---
    @@ -110,6 +110,10 @@ public abstract DataMapBuilder createBuilder(Segment segment, String shardName,
        */
       public abstract DataMapLevel getDataMapLevel();
     
    +  /**
    +   * delete datamap of the segment
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    Comments are resolved


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5715/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6955/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5737/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2461
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2461


---