[GitHub] carbondata pull request #2471: [CARBONDATA-2716][DataMap] Fix bugs in creati...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2471: [CARBONDATA-2716][DataMap] Fix bugs in creati...

qiuchenjian-2
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2471

    [CARBONDATA-2716][DataMap] Fix bugs in creating SI and bloom index in same table

    A load procedure will be started for SI and it will reuse the listeners
    which are only intended for the index datamaps. Here we will validate
    the tableName to make sure that the loading will only use the
    corresponding listerners.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata CARBONDATA-2716_si_bloom_same_table

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2471
   
----
commit 78f524d0c2264a14e4648cfd4186da1dcc719405
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-07-10T08:22:24Z

    Fix bugs in creating SI and bloom index in same table
   
    A load procedure will be started for SI and it will reuse the listeners
    which are only intended for the index datamaps. Here we will validate
    the tableName to make sure that the loading will only use the
    corresponding listerners.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2471: [CARBONDATA-2716][DataMap] Fix bugs in creating SI a...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2471
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6979/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2471: [CARBONDATA-2716][DataMap] Fix bugs in creating SI a...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2471
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5759/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2471: [CARBONDATA-2716][DataMap] Fix bugs in creating SI a...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2471
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5738/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2471: [CARBONDATA-2716][DataMap] Fix bugs in creating SI a...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2471
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2471: [CARBONDATA-2716][DataMap] Add validation for...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2471


---