[GitHub] carbondata pull request #2474: [CARBONDATA-2530] Disable the MV datamaps aft...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2474

    [CARBONDATA-2530] Disable the MV datamaps after main table load.

   
    This PR depends on https://github.com/apache/carbondata/pull/2453
    Problem:
     MV datamaps are not disabled after the main table load is done. So the wrong data is displaying.
    Solution:
    Disable the MV datamaps after main table load success.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata mv-2530

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2474
   
----
commit 844cff764e94f18ff8d115ccd636a06a0931bffb
Author: ravipesala <ravi.pesala@...>
Date:   2018-06-14T06:10:07Z

    Fixed order by in mv and aggregation functions inside projection expressions are fixed

commit 322a8710cfe71aea3f244e171954fe388e1dc474
Author: ravipesala <ravi.pesala@...>
Date:   2018-07-09T13:43:19Z

    Fix datamap disable after main table is loaded

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6982/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5741/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5769/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7187/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5849/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5962/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2474#discussion_r202544283
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -328,7 +328,7 @@ object MVHelper {
        * @return Updated modular plan.
        */
       def updateDataMap(subsumer: ModularPlan, rewrite: QueryRewrite): ModularPlan = {
    -    subsumer match {
    +     subsumer match {
    --- End diff --
   
    invalid indentation


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2474#discussion_r202544328
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/status/DataMapStatusManager.java ---
    @@ -95,7 +95,9 @@ public static void disableAllLazyDataMaps(CarbonTable table) throws IOException
             DataMapStoreManager.getInstance().getDataMapSchemasOfTable(table);
         List<DataMapSchema> dataMapToBeDisabled = new ArrayList<>(allDataMapSchemas.size());
         for (DataMapSchema dataMap : allDataMapSchemas) {
    -      if (dataMap.isLazy()) {
    +      // TODO all non datamaps like MV is now supports only lazy. Once the support is made the
    +      // following check can be removed.
    +      if (dataMap.isLazy() || !dataMap.isIndexDataMap()) {
    --- End diff --
   
    But pre-aggregate datamap supports immediate load with main table.
    `!dataMap.isIndexDataMap()` returns true for pre-aggregate datamap, right?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7196/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5971/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5862/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2474#discussion_r202888020
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/status/DataMapStatusManager.java ---
    @@ -95,7 +95,9 @@ public static void disableAllLazyDataMaps(CarbonTable table) throws IOException
             DataMapStoreManager.getInstance().getDataMapSchemasOfTable(table);
         List<DataMapSchema> dataMapToBeDisabled = new ArrayList<>(allDataMapSchemas.size());
         for (DataMapSchema dataMap : allDataMapSchemas) {
    -      if (dataMap.isLazy()) {
    +      // TODO all non datamaps like MV is now supports only lazy. Once the support is made the
    +      // following check can be removed.
    +      if (dataMap.isLazy() || !dataMap.isIndexDataMap()) {
    --- End diff --
   
    pre aggregate datamap flow is entirely different, it does not come here.


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2474#discussion_r202888035
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -328,7 +328,7 @@ object MVHelper {
        * @return Updated modular plan.
        */
       def updateDataMap(subsumer: ModularPlan, rewrite: QueryRewrite): ModularPlan = {
    -    subsumer match {
    +     subsumer match {
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7237/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6010/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7290/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6057/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5915/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2474
 
    LGTM


---