[GitHub] carbondata pull request #2475: [CARBONDATA-2531][MV] Fix alias not working o...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2475

    [CARBONDATA-2531][MV] Fix alias not working on MV query

    This PR depends on https://github.com/apache/carbondata/pull/2453
    Problem: when alias present on actual query then MV match not happening because alias is not ignored.
    Solution : Do semantic check while doing match
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata mv-2531

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2475.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2475
   
----
commit 082e19a134b18d6e2f4d705210b9d8c45acc54a5
Author: ravipesala <ravi.pesala@...>
Date:   2018-06-14T06:10:07Z

    Fixed order by in mv and aggregation functions inside projection expressions are fixed

commit 363fb6e04119b7e986f0cec20953c3dda071cc3b
Author: ravipesala <ravi.pesala@...>
Date:   2018-07-09T05:11:50Z

    Fix alias issue in mv table

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6990/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5742/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5768/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7189/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5964/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5850/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2475#discussion_r202544362
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala ---
    @@ -367,8 +367,10 @@ object GroupbyGroupbyNoChildDelta extends DefaultMatchPattern {
             if (isGroupingEmR && isGroupingRmE) {
               val isOutputEmR = gb_2q.outputList.forall {
                 case a @ Alias(_, _) =>
    -              gb_2a.outputList.exists{a1 =>
    -                a1.isInstanceOf[Alias] && a1.asInstanceOf[Alias].child.semanticEquals(a.child)
    +              gb_2a.outputList.exists{
    +                case a1: Alias =>
    +                a1.child.semanticEquals(a.child)
    --- End diff --
   
    Is this indentation correct?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7195/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5852/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5970/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5861/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2475#discussion_r202888613
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala ---
    @@ -367,8 +367,10 @@ object GroupbyGroupbyNoChildDelta extends DefaultMatchPattern {
             if (isGroupingEmR && isGroupingRmE) {
               val isOutputEmR = gb_2q.outputList.forall {
                 case a @ Alias(_, _) =>
    -              gb_2a.outputList.exists{a1 =>
    -                a1.isInstanceOf[Alias] && a1.asInstanceOf[Alias].child.semanticEquals(a.child)
    +              gb_2a.outputList.exists{
    +                case a1: Alias =>
    +                a1.child.semanticEquals(a.child)
    --- End diff --
   
    corrected


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7236/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6009/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    retest sdv please



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5951/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    LGTM
    please rebase


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7415/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2475
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6179/



---