Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

Classic

List

Threaded

105 messages Options

1234 ... 6

qiuchenjian-2

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

GitHub user kunal642 opened a pull request:

https://github.com/apache/carbondata/pull/2484

[WIP] added hadoop conf to thread local

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [ ] Any interfaces changed?

- [ ] Any backward compatibility impacted?

- [ ] Document update required?

- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/carbondata hadoop_conf_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2484

----
commit 89ff67e601ea842db2693c269f783d7ddc701c02
Author: kunal642 <kunalkapoor642@...>
Date: 2018-07-10T06:38:41Z

added hadoop conf to thread local

----

---

qiuchenjian-2

[GitHub] carbondata issue #2484: [WIP] added hadoop conf to thread local

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2484

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7012/

---

qiuchenjian-2

[GitHub] carbondata issue #2484: [WIP] added hadoop conf to thread local

In reply to this post by qiuchenjian-2

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2484

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5789/

---

qiuchenjian-2

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

In reply to this post by qiuchenjian-2

Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2484#discussion_r201612604

--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala ---
@@ -262,9 +223,9 @@ class NewCarbonDataLoadRDD[K, V](

def getInputIterators: Array[CarbonIterator[Array[AnyRef]]] = {
val attemptId = new TaskAttemptID(jobTrackerId, id, TaskType.MAP, theSplit.index, 0)
- var configuration: Configuration = getConf
+ var configuration: Configuration = CarbonRDD.getConf
if (configuration == null) {
- configuration = new Configuration()
+ configuration = CarbonRDD.getConf
--- End diff --

it should be new Configuration

---

qiuchenjian-2

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

In reply to this post by qiuchenjian-2

Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2484#discussion_r201614265

--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonRDD.scala ---
@@ -46,18 +46,12 @@ abstract class CarbonRDD[T: ClassTag](@transient sc: SparkContext,
info = new CarbonSessionInfo
info.setSessionParams(new SessionParams())
}
+ info.getThreadParams
--- End diff --

1. Here configuration should be taken from SparkSession,sessionState
2. Remove hadoopConf from constructor

---

qiuchenjian-2