[GitHub] carbondata pull request #2488: [CARBONDATA-2724][DataMap]Unsupported create ...

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest this please


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2488#discussion_r202607656
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -3231,4 +3231,42 @@ private static int unsetLocalDictForComplexColumns(List<ColumnSchema> allColumns
         }
         return columnLocalDictGenMap;
       }
    +
    +  /**
    +   * This method get the carbon file format version
    +   *
    +   * @param carbonTable
    +   * carbon Table
    +   */
    +  public static ColumnarFormatVersion getFormatVersion(CarbonTable carbonTable) throws IOException
    +  {
    +    String tablePath = carbonTable.getTablePath();
    +    CarbonFile[] carbonFiles = FileFactory
    +        .getCarbonFile(tablePath)
    +        .listFiles(new CarbonFileFilter() {
    +          @Override
    +          public boolean accept(CarbonFile file) {
    +            if (file == null) {
    +              return false;
    +            }
    +            return file.getName().endsWith("carbonindex");
    --- End diff --
   
    @ravipesala ...If dataMap is created on legacy store then in my PR I am throwing exception at the time block/blocklet pruning...but the dataMap creation blocking is not taken care in my PR...


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2488#discussion_r202609488
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -3231,4 +3231,42 @@ private static int unsetLocalDictForComplexColumns(List<ColumnSchema> allColumns
         }
         return columnLocalDictGenMap;
       }
    +
    +  /**
    +   * This method get the carbon file format version
    +   *
    +   * @param carbonTable
    +   * carbon Table
    +   */
    +  public static ColumnarFormatVersion getFormatVersion(CarbonTable carbonTable) throws IOException
    +  {
    +    String tablePath = carbonTable.getTablePath();
    +    CarbonFile[] carbonFiles = FileFactory
    +        .getCarbonFile(tablePath)
    +        .listFiles(new CarbonFileFilter() {
    +          @Override
    +          public boolean accept(CarbonFile file) {
    +            if (file == null) {
    +              return false;
    +            }
    +            return file.getName().endsWith("carbonindex");
    --- End diff --
   
    so how can we get the version info for a table?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7209/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5984/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7215/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5991/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5877/



---

[qiuchenjian-2]

Github user ndwangsen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2488#discussion_r202878487
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -3231,4 +3231,42 @@ private static int unsetLocalDictForComplexColumns(List<ColumnSchema> allColumns
         }
         return columnLocalDictGenMap;
       }
    +
    +  /**
    +   * This method get the carbon file format version
    +   *
    +   * @param carbonTable
    +   * carbon Table
    +   */
    +  public static ColumnarFormatVersion getFormatVersion(CarbonTable carbonTable) throws IOException
    +  {
    +    String tablePath = carbonTable.getTablePath();
    +    CarbonFile[] carbonFiles = FileFactory
    +        .getCarbonFile(tablePath)
    +        .listFiles(new CarbonFileFilter() {
    +          @Override
    +          public boolean accept(CarbonFile file) {
    +            if (file == null) {
    +              return false;
    +            }
    +            return file.getName().endsWith("carbonindex");
    --- End diff --
   
    I have modified the comments to get version from the data file


---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6002/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7231/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6004/



---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest sdv please


---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7234/



---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6007/



---