[GitHub] carbondata pull request #2488: [CARBONDATA-2724][DataMap]Unsupported create ...

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5885/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7244/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6018/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2488


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7256/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2488
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6032/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2488#discussion_r203248300
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -3231,4 +3232,54 @@ private static int unsetLocalDictForComplexColumns(List<ColumnSchema> allColumns
         }
         return columnLocalDictGenMap;
       }
    +
    +  /**
    +   * This method get the carbon file format version
    +   *
    +   * @param carbonTable
    +   * carbon Table
    +   */
    +  public static ColumnarFormatVersion getFormatVersion(CarbonTable carbonTable)
    +      throws IOException {
    +    String storePath = null;
    +    // if the carbontable is support flat folder
    +    boolean supportFlatFolder = carbonTable.isSupportFlatFolder();
    +    if (supportFlatFolder) {
    +      storePath = carbonTable.getTablePath();
    --- End diff --
   
    It does not work for partition tables.


---