GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2493 [HOTFIX][DataMap] Fix bugs in rebuild datamap
In cluster mode, readCommitScope is null while rebuilding datamap for
segments, this will cause NPE. Here we use the origin segment object
whose readCommitScope is not null and will work fine.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/xuchuanyin/carbondata 0711_bug_rebuild_segment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2493.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2493
----
commit f33f0a1544c06fa71c187b3c07e0e31049171846
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-07-11T14:24:54Z
Fix bugs in rebuild datamap
In cluster mode, readCommitScope is null while rebuilding datamap for
segments, this will cause NPE. Here we use the origin segment object
whose readCommitScope is not null and will work fine.
----
---
Locked
