[GitHub] carbondata pull request #2514: [CARBONDATA-2740]segment file is not getting ...

[qiuchenjian-2]

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2514

    [CARBONDATA-2740]segment file is not getting deleted if load fails and correct the error message for locla dictionary validation

    ### Problem
    error message is wrong when complex column which does not have any string datatype column is given in local dictionary and exclude column.
    when data load is failed, corresponding segment file is not getting deleted.
    ### Solution:
    error message is corrected
    when data load is failed, segment file will be deleted

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata error_message

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2514
   
----
commit 506436f80391dcf8a52520c4c2da4c03489476d5
Author: akashrn5 <akashnilugal@...>
Date:   2018-07-17T05:35:08Z

    segment file is not getting deleted if load fails and correct the error message for locla dictionary validation

----


---

[qiuchenjian-2]

Github user akashrn5 closed the pull request at:

    https://github.com/apache/carbondata/pull/2514


---

[qiuchenjian-2]

GitHub user akashrn5 reopened a pull request:

    https://github.com/apache/carbondata/pull/2514

    [CARBONDATA-2740]segment file is not getting deleted if load fails and correct the error message for local dictionary validation

    ### Problem
    error message is wrong when complex column which does not have any string datatype column is given in local dictionary exclude column.
    when data load is failed, corresponding segment file is not getting deleted.
    ### Solution:
    error message is corrected
    when data load is failed, segment file will be deleted

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata error_message

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2514
   
----
commit 506436f80391dcf8a52520c4c2da4c03489476d5
Author: akashrn5 <akashnilugal@...>
Date:   2018-07-17T05:35:08Z

    segment file is not getting deleted if load fails and correct the error message for locla dictionary validation

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7238/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6011/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5934/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    LGTM


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    retest this please


---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6200/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7445/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7455/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7467/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6215/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7469/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5986/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2514
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6225/



---