Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2519: [CARBONDATA-2747][Lucene] Fix Lucene datamap ...

Classic

List

Threaded

8 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #2519: [CARBONDATA-2747][Lucene] Fix Lucene datamap ...

GitHub user kevinjmh opened a pull request:

https://github.com/apache/carbondata/pull/2519

[CARBONDATA-2747][Lucene] Fix Lucene datamap choosing and DataMapDistributable building

1. choose lucene datamap for query column
2. build DataMapDistributable only for target datamap

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [ ] Any interfaces changed?

- [ ] Any backward compatibility impacted?

- [ ] Document update required?

- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kevinjmh/carbondata fix_lucene_query

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2519

----
commit a05cec5cab925a42875c08548dcf6b7805e94bbe
Author: Manhua <kevinjmh@...>
Date: 2018-07-18T02:14:40Z

fix lucene query

----

---

qiuchenjian-2

[GitHub] carbondata pull request #2519: [CARBONDATA-2747][Lucene] Fix Lucene datamap ...

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2519#discussion_r203245324

--- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapChooser.java ---
@@ -269,6 +270,12 @@ private void extractColumnExpression(Expression expression,
List<ColumnExpression> columnExpressions) {
if (expression instanceof ColumnExpression) {
columnExpressions.add((ColumnExpression) expression);
+ } else if (expression instanceof MatchExpression) {
+ // fake ColumnExpression for lucene. normal query string is alike "column:query term"
--- End diff --

please describe what is the use of this fake ColumnExpression.
And it is better to mention `Lucene query string` instead of `normal query string`

---

qiuchenjian-2