[GitHub] carbondata pull request #2530: [CARBONDATA-2753] Fix Compatibility issues

classic Classic list List threaded Threaded
52 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2530: [CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/2530

    [CARBONDATA-2753] Fix Compatibility issues

    **Problems:**
    (1) CarbonTable is not refreshed in the executor side with the tableproperties.
    (2) filterValues are null in case of old store.
   
    **Solution:**
    (1) Set the dictionary path to the AbsoluteTableIdentifier, so that we can get the dictionary path if needed.
    (2) Currently filterValues filling is based on the local dictionary, if the format is not V3 then the filterValues should be reassigned with the filterKeys from the ExecutorInfo.
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
            Manual Testing
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/carbondata CARBONDATA-2753

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2530
   
----
commit 0c4f559430761b612a11345ad55f957d30e826be
Author: dhatchayani <dhatcha.official@...>
Date:   2018-07-19T13:43:24Z

    [CARBONDATA-2753] Fix Compatibility issues

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6087/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7320/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6093/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7326/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7331/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6096/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7337/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7350/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5933/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6114/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7353/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6117/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7358/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7360/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7362/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2530: [WIP][CARBONDATA-2753] Fix Compatibility issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2530
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6123/



---
123