[GitHub] carbondata pull request #2555: [CARBONDATA-2753][Compatibility] Row count of...

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2555: [CARBONDATA-2753][Compatibility] Row count of...

qiuchenjian-2
GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/2555

    [CARBONDATA-2753][Compatibility] Row count of page is calculated wrong for old store(V2 store)

    Row count of page is calculated wrong for V2 store.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
           Manual Testing
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/carbondata CARBONDATA-2753_Row_Count

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2555
   
----
commit 2d893ca3fee09b6176a31f02dc84f41de5690bc7
Author: dhatchayani <dhatcha.official@...>
Date:   2018-07-25T09:11:58Z

    [CARBONDATA-2753][Compatibility] Row count of page is calculated wrong for old store(V2 store)

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6249/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7497/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6256/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7507/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Indhumathi27 commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6024/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6046/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    Retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6054/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2555
 
    @dhatchayani i have merged this pr please close


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2555: [CARBONDATA-2753][Compatibility] Row count of...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani closed the pull request at:

    https://github.com/apache/carbondata/pull/2555


---