[GitHub] carbondata pull request #2556: [CARBONDATA-2782]delete dead code in class 'C...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2556: [CARBONDATA-2782]delete dead code in class 'C...

qiuchenjian-2
GitHub user lianganping opened a pull request:

    https://github.com/apache/carbondata/pull/2556

    [CARBONDATA-2782]delete dead code in class 'CarbonCleanFilesCommand'

    the variables(dms、indexDms) in function processMetadata are nerver used.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? NA
   
     - [ ] Testing done NA
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Sssan520/carbondata issue2782

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2556
   
----
commit 83838651e9b7513963f27da49f13564d7f117a28
Author: Sssan520 <liangap2008@...>
Date:   2018-07-25T11:14:18Z

    [CARBONDATA-2782]delete dead code

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2556: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

qiuchenjian-2
Github user lianganping commented on the issue:

    https://github.com/apache/carbondata/pull/2556
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2556: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2556
 
    Can one of the admins verify this patch?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2556: [CARBONDATA-2782]delete dead code in class 'C...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user lianganping closed the pull request at:

    https://github.com/apache/carbondata/pull/2556


---