[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2572

    [CARBONDATA-2793][32k][Doc] Add 32k support in document

    Update document and add description for long string columns
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0727_32k_doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2572
   
----
commit 57d90c05b95bbd970ed911a3f2f0f6a1e7c82edf
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-07-27T08:10:44Z

    Add 32k support in document
   
    Update document and add description for long string columns

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7560/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6314/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6030/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6031/



---

[qiuchenjian-2]

Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    LGTM


---

[qiuchenjian-2]

Github user sgururajshetty commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2572#discussion_r206017345
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -283,7 +283,29 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
      ```
      ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
      ```
    -
    +
    +   - **String longer than 32000 characters**
    --- End diff --
   
    If it is a Alpha feature then please mention in the bracket that (Alpha Feature 1.4.1 )


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2572#discussion_r206104005
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -283,7 +283,29 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
      ```
      ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
      ```
    -
    +
    +   - **String longer than 32000 characters**
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7617/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6362/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    only document updated, no code related


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2572#discussion_r206416022
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -283,7 +283,30 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
      ```
      ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
      ```
    -
    +
    +   - **String longer than 32000 characters** (Alpha Feature 1.4.1)
    +
    +     In common scenarios, the length of string is less than 32000, so carbondata store the length of content using Short to reduce memory and space consumption.
    +     If your string content exceeds the 32000 characters limitation, you can specify the columns as 'long string column' using below tblProperties:
    --- End diff --
   
    comparing to previous paragram, better to describe we are using int32 to store length of the long string


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2572#discussion_r206455472
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -283,7 +283,30 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
      ```
      ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
      ```
    -
    +
    +   - **String longer than 32000 characters** (Alpha Feature 1.4.1)
    +
    +     In common scenarios, the length of string is less than 32000, so carbondata store the length of content using Short to reduce memory and space consumption.
    +     If your string content exceeds the 32000 characters limitation, you can specify the columns as 'long string column' using below tblProperties:
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7670/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7677/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7680/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6405/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7687/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2572
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6411/



---