GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2597 [CARBONDATA-2802][BloomDataMap] Remove clearing cache after rebuiding index datamap
This is no need to clear cache after rebuilding index datamap due to the
following reasons:
1. currently it will clear all the caches for all index datamaps, not
only for the current rebuilding one
2. the life cycle of table data and index datamap data is the same,
there is no need to clear it. (once the index datamap is created or
once the main table is loaded, data of the datamap will be generated too
-- in both scenarios, data of the datamap is up to date with the main
table.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`NO`
- How it is tested? Please attach test report.
`Tested in local machine`
- Is it a performance related change? Please attach the performance test report.
`NO`
- Any additional information to help reviewers in testing this change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/xuchuanyin/carbondata 0802_remove_clear_dm_4_index_dm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2597.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2597
----
commit f3c816745c8f7a829384d3241934196b1bb391ee
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-08-02T02:45:17Z
Remove clearing cache after rebuiding index datamap
This is no need to clear cache after rebuilding index datamap due to the
following reasons:
1. currently it will clear all the caches for all index datamaps, not
only for the current rebuilding one
2. the life cycle of table data and index datamap data is the same,
there is no need to clear it. (once the index datamap is created or
once the main table is loaded, data of the datamap will be generated too
-- in both scenarios, data of the datamap is up to date with the main
table.
----
---
Locked
