[GitHub] carbondata pull request #2615: [HOTFIX] [presto] presto code cleanup

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2615: [HOTFIX] [presto] presto code cleanup

qiuchenjian-2
GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/2615

    [HOTFIX] [presto] presto code cleanup

    Changes in the PR:
    a. Removed spark jars from release jars dependency
    b. enable check style for presto module
    c. fixed all the checkstyle for presto module
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? NA
     
     - [ ] Any backward compatibility impacted? NA
     
     - [ ] Document update required? NA
   
     - [ ] Testing done. NA
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2615
   
----
commit 399ca66addcd6767bc43ac7fa15514eb705546d4
Author: ajantha-bhat <ajanthabhat@...>
Date:   2018-08-06T12:21:03Z

    [HOTFIX] presto code cleanup
   
    a. Removed spark jars from release jars dependency
    b. enable check style for presto module
    c. fixed all the checkstyle for presto module

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto code cleanup

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2615
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6202/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto code cleanup

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2615
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7828/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto code cleanup

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2615
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6552/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto integration code cleanup

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2615
 
    @chenliang613 : please review.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto integration code cleanup

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2615
 
    @bhavya411 : please review


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto integration code cleanup

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2615
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2615: [HOTFIX] [presto] presto integration code cle...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2615


---