[GitHub] carbondata pull request #2623: [HOTFIX] add sk ak to file factory on creatio...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6679/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6309/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6681/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7957/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6684/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7960/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6311/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6312/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7961/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6685/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6315/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7965/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6689/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7967/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6691/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6317/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6323/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2623#discussion_r211922952
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -407,7 +407,7 @@ private void validateLockType() {
        * @param lockTypeConfigured
        */
       private void validateAndConfigureLockType(String lockTypeConfigured) {
    -    Configuration configuration = new Configuration(true);
    +    Configuration configuration = FileFactory.getConfiguration();
    --- End diff --
   
    Remove new Configuration from other places as well (CarbonUtil, DataMapLoaderRDD...etc)


---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2623#discussion_r211927982
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionWithPreaggregateTestCase.scala ---
    @@ -45,6 +45,7 @@ class StandardPartitionWithPreaggregateTestCase extends QueryTest with BeforeAnd
             | STORED BY 'org.apache.carbondata.format'
           """.stripMargin)
         sql(s"LOAD DATA LOCAL INPATH '$testData' into table maintable")
    +    sql("select * from maintable").show
    --- End diff --
   
    remove


---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2623#discussion_r211928521
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala ---
    @@ -64,6 +65,7 @@ object DataLoadProcessBuilderOnSpark {
         val sortStepRowCounter = sc.accumulator(0, "Sort Processor Accumulator")
         val writeStepRowCounter = sc.accumulator(0, "Write Processor Accumulator")
     
    +    val confBroadcast = new CarbonConfiguration(hadoopConf)
    --- End diff --
   
    rename variable to confForSerialization. Broadcast name is misleading


---