[GitHub] carbondata pull request #2623: [HOTFIX] add sk ak to file factory on creatio...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7973/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2623#discussion_r211930856
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -435,14 +436,16 @@ class CarbonScanRDD[T: ClassTag](
                   "true")
                 if (carbonRecordReader == null) {
                   new CarbonRecordReader(model,
    -                format.getReadSupportClass(attemptContext.getConfiguration), inputMetricsStats)
    +                format.getReadSupportClass(attemptContext.getConfiguration),
    --- End diff --
   
    Can we use the same conf in both places ?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6697/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2623#discussion_r211931833
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -435,14 +436,16 @@ class CarbonScanRDD[T: ClassTag](
                   "true")
                 if (carbonRecordReader == null) {
                   new CarbonRecordReader(model,
    -                format.getReadSupportClass(attemptContext.getConfiguration), inputMetricsStats)
    +                format.getReadSupportClass(attemptContext.getConfiguration),
    +                inputMetricsStats,
    +                getConf)
                 } else {
                   carbonRecordReader
                 }
               } else {
                 new CarbonRecordReader(model,
                   format.getReadSupportClass(attemptContext.getConfiguration),
    -              inputMetricsStats)
    +              inputMetricsStats, getConf)
    --- End diff --
   
    In the executor side avoid calling getConf  multiple times. Instead we can take from FileFactory.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6325/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6700/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7976/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7978/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6702/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6327/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6328/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6703/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7979/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6329/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7980/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6704/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6333/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7984/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6334/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2623
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6708/



---