[GitHub] carbondata pull request #2639: [CARBONDATA-2858] Fix external table schema b...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2639

    [CARBONDATA-2858] Fix external table schema bug

    If user specifies schema in CREATE EXTERNAL TABLE, we should:
    1. Validate the schema against the inferred schema from the table path.
    2. Honor the schema specified by the user instead of the inferred schema (full schema)
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
      two test case added  
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata fix_external_table

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2639.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2639
   
----
commit 6d14a819d3e371b8a147edee9259da5ca4a60996
Author: Jacky Li <jacky.likun@...>
Date:   2018-08-15T16:12:17Z

    fix external table

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2639#discussion_r210323933
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -324,9 +324,7 @@ object CarbonSource {
           tableDesc.copy(storage = updatedFormat)
         } else {
           val tableInfo = CarbonUtil.convertGsonToTableInfo(properties.asJava)
    -      val isExternal = properties.getOrElse("isExternal", "false")
    --- End diff --
   
    This variable is not used


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2639#discussion_r210323959
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -351,10 +349,7 @@ object CarbonSource {
           query: Option[LogicalPlan]): Map[String, String] = {
         val model = createTableInfoFromParams(properties, dataSchema, identifier, query, sparkSession)
         val tableInfo: TableInfo = TableNewProcessor(model)
    -    val isExternal = properties.getOrElse("isExternal", "false")
    --- End diff --
   
    This variable is not used


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2639
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6274/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2639
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7922/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2639
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6645/



---

[qiuchenjian-2]

Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/2639


---