[GitHub] carbondata pull request #2667: [CARBONDATA-2865] Fix StackOverflowException ...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/2667

    [CARBONDATA-2865] Fix StackOverflowException during compaction in migrated store

    **Problem:**
    When compaction is fired on migrated partition table, PartitionSpec object is unnecessarily being serialized to executor which is causing StackOverFlowException.
   
    **Solution:**
    Make PartitionSpec as transient to avoid serialization.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata compaction_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2667.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2667
   
----
commit 3ee13f1c93d1d479feba4274fb84ba0c8fd3f2c9
Author: kunal642 <kunalkapoor642@...>
Date:   2018-08-28T13:40:19Z

    fix StackOverflowException during compaction in migrated store

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6444/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/56/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8127/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6449/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/14/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    @kunal642 why does the serialization of ‘PartitionSpec’ cause stackoverflow?


---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2667
 
    @xuchuanyin Actually i was never able to find why this stackoverflow exception is thrown but while debugging i realised that a lot of recursive call is occurring when trying to serialize 'PartitionSpec'. After a little bit of searching i found a article which suggested that collections are serialized in a recursive manner. I tried this solution as i wasn't getting any other clue.


---