[GitHub] carbondata pull request #2696: [CARBONDATA-2902][DataMap] Fix showing negati...

[qiuchenjian-2]

GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/2696

    [CARBONDATA-2902][DataMap] Fix showing negative pruning result for explain command

    #2676 used method `ByteBuffer.getShort(int index)` to get number of blocklets in block, but it used wrong parameter. The `index` is index of byte instead of index of short. So it needs to multiply bytes of short type
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata explain_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2696
   
----
commit 1cdfc5c8e592f53170cf942bfbb45cc5e5d67719
Author: Manhua <kevinjmh@...>
Date:   2018-09-06T09:09:21Z

    fix negative blocklet skipped when cache level is block

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2696
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/116/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2696
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8354/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2696
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/284/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2696
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2696
 
    LGTM


---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2696
 
    This PR is already merged in this [commit](https://github.com/apache/carbondata/commit/f04850f39d8c42b96ee419140c9506f7df988075), but asfgit did not close this. Is it OK if I close this PR directly? @jackylk


---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2696
 
    I found some material which may be helpful.
   
    > A PR can be closed without committing it like so: https://mahout.apache.org/developers/github.html#closing-a-pr-without-committing-for-committers
    > Here's an example that closed https://github.com/apache/incubator-airflow/pull/2440 :
    > git commit --allow-empty -m "Closes apache/incubator-airflow#2440 *Already Merged*"
   
   
   
    Ref:
     the first comment by Chris Riccomini  in https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide


---

[qiuchenjian-2]

Github user kevinjmh closed the pull request at:

    https://github.com/apache/carbondata/pull/2696


---