[GitHub] carbondata pull request #2711: [CARBONDATA-2929][DataMap] Add block skipped ...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2711: [CARBONDATA-2929][DataMap] Add block skipped ...

qiuchenjian-2
GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/2711

    [CARBONDATA-2929][DataMap] Add block skipped info for explain command

   
    This pr will add block skipped info by counting distinct file path from hit blocklet. It shows like below:
    ```
    |== CarbonData Profiler ==
    Table Scan on test
     - total: 125 blocks, 250 blocklets
     - filter: (l_partkey <> null and l_partkey = 1006)
     - pruned by Main DataMap
        - skipped: 119 blocks, 238 blocklets
     - pruned by CG DataMap
        - name: dm
        - provider: bloomfilter
        - skipped: 6 blocks, 12 blocklets
    ```
   
    ```
    |== CarbonData Profiler ==
    Table Scan on test
     - total: 125 blocks, 250 blocklets
     - filter: TEXT_MATCH('l_shipmode:AIR')
     - pruned by Main DataMap
        - skipped: 0 blocks, 0 blocklets
     - pruned by FG DataMap
        - name: dm
        - provider: lucene
        - skipped: 12 blocks, 80 blocklets
    ```
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata explain_block_skip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2711
   
----
commit 0828b4d3f366b666602a3f9db89e862fc9bc0b89
Author: Manhua <kevinjmh@...>
Date:   2018-09-12T03:29:46Z

    add block skip info

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/243/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/412/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8482/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/249/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2711: [CARBONDATA-2929][DataMap] Add block skipped ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2711


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8487/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/417/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2711: [CARBONDATA-2929][DataMap] Add block skipped info fo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2711
 
    I think the message can be optimized from
    `- total: 125 blocks, 250 blocklets`
    to
    `- total: 125 blocks containing 250 blocklets`


---