[GitHub] carbondata pull request #2717: [CARBONDATA-2932] FIx CarbonReader Projection...

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2717: [CARBONDATA-2932] FIx CarbonReader Projection...

qiuchenjian-2
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2717

    [CARBONDATA-2932] FIx CarbonReader Projection cann't be empty exception

    run org.apache.carbondata.examples.sdk.CarbonReaderExample and then some exception.
    This PR fixd it. conclude:
    1.close carbonReader after finished read, which solved the exception.
    2.add example code for varchar and array<String>, including read and write
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ X] Any interfaces changed?
     No
     - [ X] Any backward compatibility impacted?
     No
     - [X ] Document update required?
    No
     - [X] Testing done
            fix example
     - [ X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2932-CarbonReaderProjection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2717
   
----
commit d98cbe8f0464d4bacec025d6d8fe10223cd3eac1
Author: xubo245 <xubo29@...>
Date:   2018-09-13T11:09:30Z

    [CARBONDATA-2932] FIx CarbonReader Projection cann't be empty exception

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/272/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8511/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/274/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8513/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/443/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    @xubo245 Please fix the finbugs


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/292/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8537/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/467/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    @ravipesala Please review it。


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2717: [CARBONDATA-2932] FIx CarbonReader Projection cann't...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2717
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2717: [CARBONDATA-2932] FIx CarbonReader Projection...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2717


---