[GitHub] carbondata pull request #2724: [CARBONDATA-2939] SDK interfaces are compatib...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2724

    [CARBONDATA-2939] SDK interfaces are compatible with old SDK version

    SDK interfaces are compatible with old SDK version, including CarbonReader build and CarbonWriter buildWrite*** with default null Configuration.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     compatibility old version
     - [ ] Document update required?
    Yes
     - [ ] Testing done
        add test case
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2939-compatibilitySDK

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2724
   
----
commit d2622d222c202b72204a797b57dd001c67ece200
Author: xubo245 <xubo29@...>
Date:   2018-09-15T08:26:24Z

    [CARBONDATA-2939] SDK interfaces are compatible with old SDK version
   
    fix error

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2724
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/293/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2724
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8538/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2724
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/468/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2724#discussion_r217900032
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/AvroCarbonWriterTest.java ---
    @@ -75,7 +75,7 @@ public void testWriteBasic() throws IOException {
                 "   \"fields\" : ["
                 + "{ \"name\" : \"name\", \"type\" : \"string\" },"
                 + "{ \"name\" : \"age\", \"type\" : \"int\" }]" +
    -        "}";
    +            "}";
    --- End diff --
   
    do not modify this


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2724#discussion_r217900042
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -470,11 +526,29 @@ public CarbonWriter buildThreadSafeWriterForAvroInput(org.apache.avro.Schema avr
         return new AvroCarbonWriter(loadModel, configuration);
       }
     
    +  /**
    +   * Build a {@link CarbonWriter}, which accepts Avro object
    +   *
    +   * @param avroSchema   avro Schema object {org.apache.avro.Schema}
    +   * @param numOfThreads number of threads() in which .write will be called.
    +   * @return AvroCarbonWriter
    +   * @throws IOException
    --- End diff --
   
    since you are modifying this, please complete all comment


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2724#discussion_r218276950
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/AvroCarbonWriterTest.java ---
    @@ -75,7 +75,7 @@ public void testWriteBasic() throws IOException {
                 "   \"fields\" : ["
                 + "{ \"name\" : \"name\", \"type\" : \"string\" },"
                 + "{ \"name\" : \"age\", \"type\" : \"int\" }]" +
    -        "}";
    +            "}";
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2724#discussion_r218279880
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -470,11 +526,29 @@ public CarbonWriter buildThreadSafeWriterForAvroInput(org.apache.avro.Schema avr
         return new AvroCarbonWriter(loadModel, configuration);
       }
     
    +  /**
    +   * Build a {@link CarbonWriter}, which accepts Avro object
    +   *
    +   * @param avroSchema   avro Schema object {org.apache.avro.Schema}
    +   * @param numOfThreads number of threads() in which .write will be called.
    +   * @return AvroCarbonWriter
    +   * @throws IOException
    --- End diff --
   
    ok



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2724
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/322/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2724
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8568/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2724
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/498/



---

[qiuchenjian-2]

Github user xubo245 closed the pull request at:

    https://github.com/apache/carbondata/pull/2724


---