[GitHub] carbondata pull request #2743: [CARBONDATA-2953]fixed dataload failure with ...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2743: [CARBONDATA-2953]fixed dataload failure with ...

qiuchenjian-2
GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2743

    [CARBONDATA-2953]fixed dataload failure with sort columns and query wrong result from other session

    ### Problem:
    1) when dataload is done with sort columns, it fails with following exeptions
    2) when two sessions are running in parallel, the follow below steps in session1
    drop table
    create table
    load data to table
       follow below step in session2
    query on table(select * from table limit 1), then the query returns null result instead of proper result
   
    ### Solution
    1) During sorting, the index increament for no dictionary measure data was not happening correctly, hence was trying to cast to byte array and failing
    2) If table is dropped from first session and created again, and queries from another session, the metastore needs to be updated for newly created table, but since the database in identifier was None. we were trying to get old table from default database, here need to get from current database
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata issues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2743
   
----
commit 19877ca89b515116a34108a56c07b2cd03e809bd
Author: akashrn5 <akashnilugal@...>
Date:   2018-09-20T10:09:01Z

    fixed dataload failure with sort columns and query wrong rsult from other session

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/381/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/382/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8630/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/560/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/392/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8640/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/570/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2743
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2743: [CARBONDATA-2953]fixed dataload failure with ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2743


---