[GitHub] carbondata pull request #2746: [Compatibility] fix legacy store compatibilit...

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2746: [Compatibility] fix legacy store compatibilit...

qiuchenjian-2
GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/2746

    [Compatibility] fix legacy store compatibility issue

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata compatibility_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2746
   
----
commit b0c42a913cda322d079f4206a81ff2443fdcaec0
Author: kunal642 <kunalkapoor642@...>
Date:   2018-09-21T13:13:22Z

    fix legacy store compatibility issue

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/396/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/574/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8644/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/410/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8659/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/589/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2746: [Compatibility] fix legacy store compatibilit...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 closed the pull request at:

    https://github.com/apache/carbondata/pull/2746


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2746: [Compatibility] fix legacy store compatibilit...

qiuchenjian-2
In reply to this post by qiuchenjian-2
GitHub user kunal642 reopened a pull request:

    https://github.com/apache/carbondata/pull/2746

    [Compatibility] fix legacy store compatibility issue

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata compatibility_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2746
   
----
commit d8b35ef735cc49d36fc0ece98570953d6a610133
Author: kunal642 <kunalkapoor642@...>
Date:   2018-09-21T13:13:22Z

    fix legacy store compatibility issue

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/418/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/597/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8667/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/436/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8685/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/615/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2746
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2746: [Compatibility] fix legacy store compatibilit...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2746


---