[GitHub] carbondata pull request #2776: [HOTFIX] Remove empty table property

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2776: [HOTFIX] Remove empty table property

qiuchenjian-2
GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2776

    [HOTFIX] Remove empty table property

    When using CarbonCli to print table property of the table, it prints:
    ```
    ## Table Properties
    Property Name              Property Value                                                    
    'sort_columns'             'l_shipdate,l_returnflag,l_shipmode,l_receiptdate,l_shipinstruct'  
    'table_blocksize'          '256'                                                              
    'no_inverted_index'        'l_shipdate,l_returnflag,l_shipmode,l_receiptdate,l_shipinstruct'  
    'comment'                  ''                                                                
    'bad_records_path'         ''                                                                
    'local_dictionary_enable'  'true'  
    ```
    As shown, there are some empty properties written, this PR remove these empty properties
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata remove_tblproperty

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2776
   
----
commit 2b2d2b6d80dc7eae994cd2d876e40a7527469504
Author: Jacky Li <jacky.likun@...>
Date:   2018-09-27T14:28:18Z

    remove empty table property

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2776: [HOTFIX] Avoid adding empty table property

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2776
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/803/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2776: [HOTFIX] Avoid adding empty table property

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2776
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8872/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2776: [HOTFIX] Avoid adding empty table property

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/2776


---