[GitHub] carbondata pull request #2777: [HOXFIX] Upgrade spark integration version to...

[qiuchenjian-2]

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/carbondata/pull/2777

    [HOXFIX] Upgrade spark integration version to  2.3.2

    1. Upgrade spark integration version to  2.3.2
    2. Currently, hive integration module is not supported along with spark 2.3.2, so remove it in pom.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/carbondata spark2.3.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2777
   
----
commit e75dde20946873ef42f8c447c71c980375c76a96
Author: chenliang613 <chenliang613@...>
Date:   2018-09-27T15:10:15Z

    [HOXFIX] upgrade spark integration version to  2.3.2

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2777#discussion_r220969519
 
    --- Diff: pom.xml ---
    @@ -608,13 +608,12 @@
         <profile>
           <id>spark-2.3</id>
           <properties>
    -        <spark.version>2.3.1</spark.version>
    +        <spark.version>2.3.2</spark.version>
             <scala.binary.version>2.11</scala.binary.version>
             <scala.version>2.11.8</scala.version>
           </properties>
           <modules>
             <module>integration/spark2</module>
    -        <module>integration/hive</module>
    --- End diff --
   
    do not remove it, otherwise compile error can not be found by CI


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2777
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/613/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2777
 
    @chenliang613, there are some


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2777
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8874/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2777
 
    @chenliang613 there are some interface changes in Spark 2.3.2, so it needs to change some code to upgrade spark version to 2.3.2, I raised #2779 to fix some issues, please review.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2777
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/805/



---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2777#discussion_r221129765
 
    --- Diff: pom.xml ---
    @@ -608,13 +608,12 @@
         <profile>
           <id>spark-2.3</id>
           <properties>
    -        <spark.version>2.3.1</spark.version>
    +        <spark.version>2.3.2</spark.version>
             <scala.binary.version>2.11</scala.binary.version>
             <scala.version>2.11.8</scala.version>
           </properties>
           <modules>
             <module>integration/spark2</module>
    -        <module>integration/hive</module>
    --- End diff --
   
    hive integration with spark 2.3.2 is not working.


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2777
 
    same as #2779 , so close this pr.


---

[qiuchenjian-2]

Github user chenliang613 closed the pull request at:

    https://github.com/apache/carbondata/pull/2777


---