[GitHub] carbondata pull request #2782: [CARBONDATA-2984][Streaming] Fix NPE when the...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/2782

    [CARBONDATA-2984][Streaming] Fix NPE when there is no data in the task of a batch

    Fix NPE when there is no data in the task of a batch
   
     - [x] Any interfaces changed?
     no
     - [x] Any backward compatibility impacted?
     no
     - [x] Document update required?
     no
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
               add test case
            - How it is tested? Please attach test report.
            - Is it a performance-related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    small changes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata streaming_index_null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2782
   
----
commit 8bf52f72e6532ec9b04ac5130fcd8011d4721c95
Author: QiangCai <qiangcai@...>
Date:   2018-09-28T06:48:39Z

    fix NPE when there is no data in the task of a batch

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/625/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/817/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8886/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2782#discussion_r221226631
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala ---
    @@ -2327,7 +2371,7 @@ class TestStreamingTableOperation extends QueryTest with BeforeAndAfterAll {
                 .load()
     
               // Write data from socket stream to carbondata file
    -          qry = readSocketDF.writeStream
    +          qry = readSocketDF.repartition(2).writeStream
    --- End diff --
   
    Is this the place to generate empty rows to insert to streaming file?


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    the testcases in `TestStreamingTableOperation.scala` are tight independent with each other, I suggest you to refactor before adding more tests.


---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    @xuchuanyin different test cases use different tables, they are independent.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/646/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8909/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/841/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2782#discussion_r221444696
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala ---
    @@ -2327,7 +2371,7 @@ class TestStreamingTableOperation extends QueryTest with BeforeAndAfterAll {
                 .load()
     
               // Write data from socket stream to carbondata file
    -          qry = readSocketDF.writeStream
    +          qry = readSocketDF.repartition(2).writeStream
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    can this pr already be merged?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2782
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2782


---