[GitHub] carbondata pull request #2793: [CARBONDATA-2990] Fixed JVM crash when rebuil...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2793

    [CARBONDATA-2990] Fixed JVM crash when rebuilding bloom datamap.

    Problem: while rebuilding the datamap it access the datamap store so it builds datamap and store in unsafe onheap storage. But while closing the reader it frees all memory acquired during that task. Since acquired memory is onheap but releasing the memory with offheap allocator it crashes the jvm.
   
    Solution: Maintain the type of memory acquired in the memory block itself and get the allocator as per the memory type and release it.
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata bloom-jvm-crash

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2793.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2793
   
----
commit bf8f731e21fe9ba0e0a56c75138d72bf87d0d187
Author: ravipesala <ravi.pesala@...>
Date:   2018-09-30T05:57:57Z

    Fixed JVM crash when rebuilding bloom datamap.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/659/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/853/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8922/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    @ravipesala Can you explain why the JVM crash issue does not happened in our tests, cause we also have tests for rebuilding datamap.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    @xuchuanyin It can happen only in a cluster, that's why it is not caught in UT.


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2793#discussion_r222318367
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java ---
    @@ -217,6 +212,17 @@ public static MemoryBlock allocateMemoryWithRetry(MemoryAllocator memoryAllocato
         return baseBlock;
       }
     
    +  private MemoryAllocator getMemoryAllocator(MemoryType memoryType) {
    +    switch (memoryType) {
    +      case ONHEAP:
    +        return MemoryAllocator.HEAP;
    +      case OFFHEAP:
    +        return MemoryAllocator.UNSAFE;
    +      default:
    +        return MemoryAllocator.UNSAFE;
    --- End diff --
   
    combine OFFHEAP and default case as one
    `case OFFHEAP:
    default:
    return MemoryAllocator.UNSAFE;`


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    @ravipesala Why does it only occur in cluster mode? Just in curious


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2793#discussion_r222546168
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java ---
    @@ -217,6 +212,17 @@ public static MemoryBlock allocateMemoryWithRetry(MemoryAllocator memoryAllocato
         return baseBlock;
       }
     
    +  private MemoryAllocator getMemoryAllocator(MemoryType memoryType) {
    +    switch (memoryType) {
    +      case ONHEAP:
    +        return MemoryAllocator.HEAP;
    +      case OFFHEAP:
    +        return MemoryAllocator.UNSAFE;
    +      default:
    +        return MemoryAllocator.UNSAFE;
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    @xuchuanyin Since both driver and executor exists in the same JVM, it can get segment properties from blocklet datamap without loading them again in executor side, so no need to clear in executor side in case of noncluster mode.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/696/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8961/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/893/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2793
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2793


---