[GitHub] carbondata pull request #2797: [CARBONDATA-2993] fix random NPE while concur...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2797: [CARBONDATA-2993] fix random NPE while concur...

qiuchenjian-2
GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/2797

    [CARBONDATA-2993] fix random NPE while concurrent loading

    **Problem:** NPE is thrown from CarbonRDD during concurrent dataload.
    This is due to configuration being extracted from broadcast variable and sometimes it gives null instead of hadoopconfiguration.
   
    **Solution:** Keep Hadoop Conf as a transient class level variable for driver and extract from broadcast in executor.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata NPE_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2797.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2797
   
----
commit 6b29533d1ac788a6e687daad95bb39c6c92079dd
Author: kunal642 <kunalkapoor642@...>
Date:   2018-10-05T04:43:05Z

    fix random NPE while concurrent loading due to broadcast configuration variable in driver

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2797: [CARBONDATA-2993] fix random NPE while concurrent lo...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2797
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/717/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2797: [CARBONDATA-2993] fix random NPE while concurrent lo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2797
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8981/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2797: [CARBONDATA-2993] fix random NPE while concurrent lo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2797
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/913/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2797: [CARBONDATA-2993] fix random NPE while concurrent lo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2797
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2797: [CARBONDATA-2993] fix random NPE while concur...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2797


---