GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2812 [CARBONDATA-3004][32k] Fix bugs in writing dataframe to carbon with longstring
Currently while writing dataframe to carbon table, we need to parse the
rows in dataframe. For string columns, we need to judge whether it is a
long string column or not. In current implementation, the judgement is
position based which means that the order of fields in dataframe should
be the same as that in create table. In this PR, we fix this bug.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`Added tests for this`
- How it is tested? Please attach test report.
`Tested in local`
- Is it a performance related change? Please attach the performance test report.
`NO`
- Any additional information to help reviewers in testing this change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/xuchuanyin/carbondata 181012_longstring_df_append_seq
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2812.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2812
----
commit 94310af9343f0a27f3246e3d0679ba77def03191
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-10-12T08:20:58Z
Fix bugs in writing dataframe to carbon with longstring
Currently while writing dataframe to carbon table, we need to parse the
rows in dataframe. For string columns, we need to judge whether it is a
long string column or not. In current implementation, the judgement is
position based which means that the order of fields in dataframe should
be the same as that in create table. In this PR, we fix this bug.
----
---
Locked
