[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

classic Classic list List threaded Threaded
76 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

qiuchenjian-2
GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/2872

    [WIP] Added reusable buffer code

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata 2863

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2872
   
----
commit d382d8d92e91a9b20a1b95dcdf4724ee21969b37
Author: ravipesala <ravi.pesala@...>
Date:   2018-10-26T15:20:53Z

    Optimize decompressing while filling the vector during conversion of primitive types

commit bd00dfbab9208f3f82cdf5a357b57b0933285152
Author: kumarvishal09 <kumarvishal1802@...>
Date:   2018-10-28T15:09:05Z

    reusable byteArray

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9371/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1321/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1110/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9375/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1113/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1116/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2872#discussion_r228901408
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/ZstdCompressor.java ---
    @@ -167,4 +167,12 @@ public long maxCompressedLength(long inputSize) {
       public boolean supportUnsafe() {
         return false;
       }
    +
    +  @Override public int uncompressedLength(byte[] data, int offset, int length) {
    --- End diff --
   
    Why this is unsupported since this is supported in Zstd
    ```
        /**
         * Return the original size of a compressed buffer (if known)
         *
         * @param src the compressed buffer
         * @return the number of bytes of the original buffer
         *         0 if the original size is now known
         */
        public static native long decompressedSize(byte[] src);
    ```
   
   
   



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2872#discussion_r228902627
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPageByteUtil.java ---
    @@ -0,0 +1,49 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +/**
    + * Utility methods to converts to primitive types only column page data decode.
    + */
    +public class ColumnPageByteUtil {
    --- End diff --
   
    What's the difference between this and `ByteUtil.java`?
    I see the same name of function with different implementations, please consider to optimize and add some notes.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1327/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2872#discussion_r228915419
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPageByteUtil.java ---
    @@ -0,0 +1,49 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +/**
    + * Utility methods to converts to primitive types only column page data decode.
    + */
    +public class ColumnPageByteUtil {
    --- End diff --
   
    @xuchuanyin This PR depends on 2863


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2872#discussion_r228915613
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/ZstdCompressor.java ---
    @@ -167,4 +167,12 @@ public long maxCompressedLength(long inputSize) {
       public boolean supportUnsafe() {
         return false;
       }
    +
    +  @Override public int uncompressedLength(byte[] data, int offset, int length) {
    --- End diff --
   
    @xuchuanyin Still we are working on it. This is not final code


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9379/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1128/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1338/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9392/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1422/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1207/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1208/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1423/



---
1234