[GitHub] carbondata pull request #2873: [WIP] Fix partition load issue when custom lo...

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2873: [WIP] Fix partition load issue when custom lo...

qiuchenjian-2
GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2873

    [WIP] Fix partition load issue when custom location is added.

    Problem:
    Load files from carbonfile format when custom partition location is added
   
    Reason:
    Carbon has its own filename for each carbondata file, it does not use the filename proposed by spark. And also it has extra index file need to be created. In case of custom partition location sparks keep track the files of name which creates and move them. But carbon has different files created and maintained, that creates the filenot found exception.
   
    Solution:
    Use custom protocol to manage commit and folder location for custom partition location.
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata partition-fileformat-issues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2873
   
----
commit fac461a17ef94b1b0967b726b5bf99b1dea9702e
Author: ravipesala <ravi.pesala@...>
Date:   2018-10-29T07:45:00Z

    Fix partition load issue when custom location is added.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1333/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1121/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9385/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1155/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1372/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9423/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1181/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1394/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2873: [WIP] Fix partition load issue when custom location ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2873
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9445/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2873: [CARBONDATA-3070] Fix partition load issue wh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2873


---