[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

classic Classic list List threaded Threaded
65 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

qiuchenjian-2
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2875

    [CARBONDATA-3038] Refactor dynamic configuration

    1.remove CarbonProperty annotation, and DynamicConfigurable, NonDynamicConfigurable, DefaultValue,Threshold and so on
    2.unify default value variable name: XX_XX_DEFAULT
    3.optimize the properties: remove some warning
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    change the doc
     - [ ] Testing done
          no
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-3038_RefactorConfiguration

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2875
   
----
commit 436746f923f90d9db23c6a53a30e39d97a88042d
Author: xubo245 <xubo29@...>
Date:   2018-10-29T11:09:15Z

    [CARBONDATA-3038] Refactor dynamic configuration
    1.remove CarbonProperty annotation, and DynamicConfigurable, NonDynamicConfigurable, DefaultValue,Threshold and so on
    2.unify default value variable name: XX_XX_DEFAULT
    3.optimize the properties: remove some warning
   
    optmize

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [WIP][CARBONDATA-3038] Refactor dynamic configuratio...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9383/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [WIP][CARBONDATA-3038] Refactor dynamic configuratio...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1331/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [WIP][CARBONDATA-3038] Refactor dynamic configuratio...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1119/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1186/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1400/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9452/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1198/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1413/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9462/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1438/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1223/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9487/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1226/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1441/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9490/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1229/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1444/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2875
 
    retest this please


---
1234