Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629760
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -117,77 +126,106 @@ private CarbonCommonConstants() {
* CARBON_TIMESTAMP
*/
public static final String CARBON_TIMESTAMP_MILLIS = "dd-MM-yyyy HH:mm:ss:SSS";
+
/**
- * compressor for writing/reading carbondata file
+ * Property for specifying the format of DATE data type column.
+ * e.g. yyyy/MM/dd , or using default value
*/
+ @CarbonProperty
+ public static final String CARBON_DATE_FORMAT = "carbon.date.format";
+
+ /**
+ * default value
+ */
+ public static final String CARBON_DATE_DEFAULT_FORMAT = "yyyy-MM-dd";
+
+ /**
+ * compressor for writing/reading CarbonData file
+ */
+ @CarbonProperty
public static final String COMPRESSOR = "carbon.column.compressor";
/**
* default compressor is snappy
*/
public static final String DEFAULT_COMPRESSOR = "snappy";
+
/**
- * ZOOKEEPER_ENABLE_LOCK if this is set to true then zookeeper will be used to handle locking
+ * ZOOKEEPER_ENABLE_LOCK if this is set to true then zookeeper
+ * will be used to handle locking
* mechanism of carbon
*/
@CarbonProperty
public static final String LOCK_TYPE = "carbon.lock.type";
+ /**
+ * ZOOKEEPER_ENABLE_DEFAULT the default value for zookeeper will be true for carbon
+ */
+ public static final String LOCK_TYPE_DEFAULT = "LOCALLOCK";
+
/**
* Specifies the path where the lock files have to be created.
* By default, lock files are created in table path.
*/
@CarbonProperty
public static final String LOCK_PATH = "carbon.lock.path";
- /**
- * ZOOKEEPER_ENABLE_DEFAULT the default value for zookeeper will be true for carbon
- */
- public static final String LOCK_TYPE_DEFAULT = "LOCALLOCK";
+ public static final String LOCK_PATH_DEFAULT = "";
/**
* ZOOKEEPER_LOCATION this is the location in zookeeper file system where locks are created.
* mechanism of carbon
*/
public static final String ZOOKEEPER_LOCATION = "/CarbonLocks";
+
/**
- * xxhash algorithm property for hashmap
+ * xxhash algorithm property for hashMap
*/
+ @CarbonProperty
public static final String ENABLE_XXHASH = "carbon.enableXXHash";
/**
- * xxhash algorithm property for hashmap. Default value false
+ * xxhash algorithm property for hashMap Default value false
*/
public static final String ENABLE_XXHASH_DEFAULT = "true";
+
/**
* System property to enable or disable local dictionary generation
*/
+ @CarbonProperty
public static final String LOCAL_DICTIONARY_SYSTEM_ENABLE = "carbon.local.dictionary.enable";
/**
* System property to enable or disable decoder based local dictionary fallback
*/
+ @CarbonProperty
public static final String LOCAL_DICTIONARY_DECODER_BASED_FALLBACK =
"carbon.local.dictionary.decoder.fallback";
/**
* System property to enable or disable decoder based local dictionary fallback default value
*/
public static final String LOCAL_DICTIONARY_DECODER_BASED_FALLBACK_DEFAULT = "true";
+
/**
* zookeeper url key
*/
+ @CarbonProperty
public static final String ZOOKEEPER_URL = "spark.deploy.zookeeper.url";
+
/**
* carbon data file version property
*/
+ @CarbonProperty
public static final String CARBON_DATA_FILE_VERSION = "carbon.data.file.version";
+
@CarbonProperty
public static final String SPARK_SCHEMA_STRING_LENGTH_THRESHOLD =
"spark.sql.sources.schemaStringLengthThreshold";
public static final int SPARK_SCHEMA_STRING_LENGTH_THRESHOLD_DEFAULT = 4000;
+ //TODO: add annotation and whether change to dynamic
--- End diff --
ok, done
---
Locked
