[GitHub] carbondata pull request #2905: [TEST] Skip writing MDK

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2905

    [TEST] Skip writing MDK

   
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata remove_mdk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2905.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2905
   
----
commit dfbe692ea4cfe5ae1323916f875f3ec56ba79e70
Author: Jacky Li <jacky.likun@...>
Date:   2018-11-06T15:58:44Z

    remove mdk

commit 8e7cb162e48f10590ac5ba7cfbc0101bdb7e77f0
Author: Jacky Li <jacky.likun@...>
Date:   2018-11-06T16:07:17Z

    wip

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2905
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1321/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2905
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9579/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2905
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1532/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2905
 
    Previously we include the sort_columns and global dictionary columns in MDK. Will this PR affect the legacy store?
   
    Besides, for datamap we have to parse the MDK to get the real value, these related procedures also need to be modified.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2905
 
    @xuchuanyin I just want to get a CI report to check whether it is possible. As the CI finished, I will close this PR


---

[qiuchenjian-2]

Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/2905


---