[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2914

    [WIP][CARBONDATA-3093] Provide property builder for carbon properties.

    [CARBONDATA-3093] Provide property builder for carbon properties.
    Optimize the String implementation, we can provide property builder for it, then can use it in CarbonCommonConstant to replace current String implementation.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-3093_RefactorConfiguration

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2914.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2914
   
----
commit 55dfd935f21e66334c41a8e2ae3c9830fde78805
Author: xubo245 <xubo29@...>
Date:   2018-11-12T10:50:00Z

    [CARBONDATA-3093] Provide property builder for carbon properties.
   
    optimize

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232628355
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = "carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = Property.buildStringProperty()
    --- End diff --
   
    I think this should be boolean property


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232628397
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = "carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = Property.buildStringProperty()
    +      .key("carbon.enable.vector.reader")
    --- End diff --
   
    rename to `name`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232628480
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = "carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = Property.buildStringProperty()
    --- End diff --
   
    I think this should be boolean property



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232629531
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = "carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = Property.buildStringProperty()
    +      .key("carbon.enable.vector.reader")
    +      .defaultValue("true")
    +      .doc("enable vector read")
    --- End diff --
   
    document should be more descriptive


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1369/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232632618
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = "carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = Property.buildStringProperty()
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232632711
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = "carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = Property.buildStringProperty()
    +      .key("carbon.enable.vector.reader")
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2914#discussion_r232632794
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1237,10 +1238,12 @@ private CarbonCommonConstants() {
        */
       public static final String MIN_MAX_DEFAULT_VALUE = "true";
     
    -  @CarbonProperty(dynamicConfigurable = true)
    -  public static final String ENABLE_VECTOR_READER = "carbon.enable.vector.reader";
    -
    -  public static final String ENABLE_VECTOR_READER_DEFAULT = "true";
    +  public static final Property ENABLE_VECTOR_READER = Property.buildStringProperty()
    +      .key("carbon.enable.vector.reader")
    +      .defaultValue("true")
    +      .doc("enable vector read")
    --- End diff --
   
    ok, I will raise a another PR for it.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1371/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1372/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9630/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1582/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1373/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1583/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9631/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1564/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1566/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9824/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2914
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1777/



---