[GitHub] carbondata pull request #2941: [WIP] Support CarbonSession from pyspark shel...

[qiuchenjian-2]

GitHub user sraghunandan opened a pull request:

    https://github.com/apache/carbondata/pull/2941

    [WIP] Support CarbonSession from pyspark shell

    Added support for Creating CarbonSession from pyspark shell
   
     - [X] Any interfaces changed?
     No existing interfaces
     - [X] Any backward compatibility impacted?
     NO
     - [X] Document update required?
    YES
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
    YES      
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sraghunandan/carbondata-1 python_support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2941
   
----
commit 1a08a372335296f7bed961398d23b32504d242ad
Author: Raghunandan S <carbondatacontributions@...>
Date:   2018-11-22T02:40:21Z

    Support CarbonSession from pyspark shell

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2941
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1503/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2941
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9761/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2941
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1713/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2941#discussion_r236035495
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.py ---
    @@ -0,0 +1,122 @@
    +from __future__ import print_function
    --- End diff --
   
    license header is required


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2941#discussion_r236035500
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.py ---
    @@ -0,0 +1,122 @@
    +from __future__ import print_function
    +import sys
    +from threading import RLock
    +
    +if sys.version >= '3':
    +    basestring = unicode = str
    +    xrange = range
    +else:
    +    from itertools import izip as zip, imap as map
    +
    +from pyspark.sql.conf import RuntimeConfig
    +
    +__all__ = ["CarbonSession"]
    +
    +
    +class CarbonSession(object):
    --- End diff --
   
    please add comment to this file


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2941#discussion_r236035510
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/__init__.py ---
    @@ -0,0 +1,6 @@
    +from __future__ import absolute_import
    +
    +
    +__all__ = [
    --- End diff --
   
    I think it is better to add example and doc to describe how to use it in the same PR


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2941
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1973/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2941
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10225/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2941
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2246/



---